-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batch trust regions implementation of TURBO #791
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khurram-ghani
requested review from
uri-granta,
hstojic,
henrymoss and
vpicheny
November 29, 2023 19:58
uri-granta
reviewed
Nov 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(still looking but a few initial comments as I might not get a chance to get back to this before tomorrow)
uri-granta
reviewed
Dec 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(A few more comments...)
uri-granta
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)/PRs: None
Summary
This PR adds a TURBO implementation based on the new batch-trust-region classes and replaces the original
TURBO
implementation.The entry point
filter_datasets
in acquisition rules from the earlier local-models PR is called after acquisition and observation of new query-points, but before model training. Trust region algorithms do not update their regions inacquire
anymore, instead the update is now in this new method. This enables the behaviour of the newTURBOBox
class to match the previousTURBO
implementation.Existing notebook, unit tests and integration tests have been updated to use the new classes. The
trust_region
notebook shows how local models can be used withTURBOBox
.Fully backwards compatible: no
We have agreed that we don't need backwards compatibility.
Previously, a
TURBO
rule was created like this:This will need to be replaced with the following:
PR checklist